Merged
Conversation
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to upload TAR files in addition to ZIP files to Google Cloud Storage. A ContentType enum is added to distinguish between file types, and the uploadObject function is updated to handle both .zip and .tar.gz files based on this new parameter.
My review has identified a critical bug in the file extension validation for .tar.gz files. I've also included suggestions to improve code quality by using strict equality checks and updating documentation to reflect the new functionality. Please address the critical issue and consider the other suggestions for improvement.
Yuangwang
approved these changes
Dec 2, 2025
andrewbrook
pushed a commit
that referenced
this pull request
Dec 16, 2025
* Allow TAR uploads to storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow Tar uploads to storage.
(Necessary for zip deploy)